[automatic-failover] Implement weighted endpoint selection #3519
+90
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add HealthStatus
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a HealthStatus enum and refactors the failover logic to use health-based endpoint selection instead of directly checking circuit breaker states. The changes simplify the configuration by removing the RedisDatabaseConfig inner class and having RedisDatabase accept DatabaseConfig directly.
Key Changes:
- Added
HealthStatusenum with UNKNOWN, HEALTHY, and UNHEALTHY states - Refactored
RedisDatabaseto useDatabaseConfigdirectly instead of innerRedisDatabaseConfigclass - Updated failover logic in
StatefulRedisMultiDbConnectionImplto filter by health status instead of circuit breaker state
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| HealthStatus.java | New enum defining health states (UNKNOWN, HEALTHY, UNHEALTHY) for database endpoints |
| RedisDatabase.java | Removed inner RedisDatabaseConfig class, added healthStatus field with getter, updated constructor to accept DatabaseConfig directly |
| StatefulRedisMultiDbConnectionImpl.java | Renamed getHealthyDatabase to getNextHealthyDatabase, changed filtering from circuit breaker state to health status, improved error handling with orElse(null) |
| MultiDbClientImpl.java | Simplified database creation by passing DatabaseConfig directly instead of wrapping in RedisDatabaseConfig |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Show resolved
Hide resolved
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Outdated
Show resolved
Hide resolved
atakavci
changed the title
ggivo
reviewed
Nov 21, 2025
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Show resolved
Hide resolved
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Outdated
Show resolved
Hide resolved
tishun
reviewed
Nov 24, 2025
Collaborator
tishun
left a comment
tishun
left a comment
There was a problem hiding this comment.
I do not have any general concerns beside the assumption this is a partial change and this is why the health state is not mutable at all (as far as I can tell)
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Show resolved
Hide resolved
src/main/java/io/lettuce/core/failover/StatefulRedisMultiDbConnectionImpl.java
Show resolved
Hide resolved
- rename predicate function - add javadoc
ggivo
reviewed
Nov 26, 2025
tishun
approved these changes
Nov 26, 2025
Comment on lines
+6
to
+19
| * | ||
| * This file contains contributions from third-party contributors | ||
| * licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
Collaborator
There was a problem hiding this comment.
For new files we can omit this part, only the first 3 lines are required
atakavci
merged commit 5f3060f
into
redis:feature/automatic-failover-1
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is half baked weighted endpoint selection in current implementation. This PR introduces the proper health status check while improves the overall quality of the code.
HealthStatusEnumRedisDatabase.RedisDatabaseConfiginner classRedisDatabasenow acceptsDatabaseConfigdirectlygetNextHealthyDatabase